Print Page - Menu me this....

BASIC User Group => Code Challenges => Topic started by: AIR on October 22, 2018, 12:07:41 PM

Title: Menu me this....
Post by: AIR on October 22, 2018, 12:07:41 PM

Okay, so here's a coding challenge that can be used in the real world. I had to do this for multiple OS's for work.

It's a terminal-based front-end to back up user data (I'm excluding the backup part).

The idea is to present the user/technician with a menu were they can select a user to backup.

Requirements:

A menu with a title
The ability to pass both the Menu Title and the Home Folder location where the user data is stored (under *nix this is typically "/home", on macOS/Windows it's "/Users")
The ability to specify exclusions so that certain accounts/folders are NOT displayed
The menu needs to list a number associated with the user id, and the user logon id itself
A prompt that only accepts numerical input, within the range specified in the menu
A warning message if the input is not in range
Upon a successful selection, output the user id that was selected

Here is an implementation in Bash (more to come):

Code: Bash

#!/bin/bash
 
EXCLUDE='Shared|Guest'
 
function SelectFolder() {
    # PARAMETERS:
    #    $1 - Menu Title
    #    $2 - User Folders Location
 
    clear
    TITLE="$1"
    TLEN=${#TITLE}
 
    echo "$TITLE"
    printf %${TLEN}s | tr " " "="
    echo
 
    USER_LOC=$(ls "$2" | egrep -v $EXCLUDE)
 
    PS3="Select User: "
 
    select USER_ACCOUNT in $USER_LOC; do
        test -n "$USER_ACCOUNT" && break
        echo ">>> Invalid Selection <<<"
    done
}
 
# change the second parameter depending on OS...
SelectFolder "Armando's Test Menu" "/Users"
 
printf "\nYou Selected: $USER_ACCOUNT\n"
 

AIR.

Title: Re: Menu me this....
Post by: AIR on October 22, 2018, 12:14:08 PM

PYTHON VERSION

(It's an OPEN FORUM after all!!! 8))

Code: Python

#!/usr/bin/env python
 
import glob,os,sys,time
 
excluded = '''Shared 
              Guest'''.split()
                          
def clear():
        sys.stderr.write("\x1b[2J\x1b[H")
 
def SelectFolder(menu_title,path):
 
        loop = True
        selection = {}
        x = [x for x in glob.glob(path+'/*') if os.path.isdir(x) and not (os.path.basename(x) in excluded)]
        while loop:
                clear()
                print menu_title.center(30,"-")
 
                for cnt,item in enumerate(x):
                        print '{}) {}'.format(cnt+1, os.path.basename(item))
                        selection[str(cnt+1)] = item
 
                print "-"*30
                print
                choice = raw_input('Select a User Folder: ')
 
                try:
                        selected = selection[choice]
                        loop = False
                except KeyError:
                        print ">> Invalid Selection <<"
                        time.sleep(1)
                        continue
 
        return selected
 
# change second parameter according to OS...
selected = SelectFolder(" Armando's Test Menu ",'/Users')
print "\nYou Selected: %s" % os.path.basename(selected)
 

AIR.

Title: Re: Menu me this....
Post by: AIR on October 22, 2018, 12:18:08 PM

And for all the BASIC enthusiasts, a BACON VERSION ;D

Code: Text

DECLARE Exclude$ = "Guest|Shared"
 
FUNCTION SelectFolder$(Title$, Folder$)
    LOCAL Menu$ ASSOC STRING
    LOCAL tLen,cnt,Amount TYPE int
    LOCAL Border$ TYPE STRING
    LOCAL Loop TYPE bool
 
    tLen = LEN(Title$)
    Loop = TRUE
    Border$ = FILL$(LEN(Title$), 45 )
 
    WHILE Loop
        Count = 1
        OPEN Folder$ FOR DIRECTORY AS mydir
 
        CLEAR
 
        PRINT Title$
 
        PRINT Border$
 
        REPEAT
            GETFILE myfile$ FROM mydir
            IF LEFT$(myfile$,1)== "." OR ISFALSE(LEN(myfile$)) OR REGEX(myfile$,Exclude$) THEN
                CONTINUE
            ELSE
                Menu$(STR$(Count)) = myfile$
                PRINT Count,") ", myfile$
                INCR Count
            ENDIF
        UNTIL ISFALSE(LEN(myfile$))
        
        CLOSE DIRECTORY mydir
 
        PRINT Border$
        
        Amount = NRKEYS(Menu$)
        PRINT
 
        INPUT "Select User: ",Selection$
        blah = VAL(Selection$)
        IF (blah < 1 OR blah > Amount) THEN
            PRINT ">>> Invalid Selection <<"
            SLEEP 1000
            CONTINUE
        ELSE
            Loop = FALSE
        ENDIF
    WEND
    RETURN Menu$(Selection$)
END FUNCTION
 
selected$ = SelectFolder$("Armando's Test Menu","/Users")
 
PRINT
PRINT "You Selected: ", selected$
 

AIR.

Title: Re: Menu me this....
Post by: John on October 22, 2018, 12:43:23 PM

Would it be okay if I submitted my Script BASIC cross platform command line backup select utility to accept a path/file mask as an argument so the utility could be used in a 'batch' file? STDIO

Title: Re: Menu me this....
Post by: AIR on October 22, 2018, 12:45:00 PM

Sure, as long as the core requirements are met.

Title: Re: Menu me this....
Post by: John on October 22, 2018, 12:57:39 PM

I should have read your requirements better. >:(

I thought you were looking for a frontend file select with a default prefix directory path.

I'll give your requirements a try.

Title: Re: Menu me this....
Post by: John on October 22, 2018, 02:20:18 PM

I gave your BaCon example a try but had to make the _Bool change and change /Users to /home.

Code: [Select]

    DECLARE Exclude$ = "Guest|Shared"

    FUNCTION SelectFolder$(Title$, Folder$)
        LOCAL Menu$ ASSOC STRING
        LOCAL tLen,cnt,Amount TYPE int
        LOCAL Border$ TYPE STRING
        LOCAL Loop TYPE _Bool

        tLen = LEN(Title$)
        Loop = TRUE
        Border$ = FILL$(LEN(Title$), 45 )

        WHILE Loop
            Count = 1
            OPEN Folder$ FOR DIRECTORY AS mydir

            CLEAR

            PRINT Title$

            PRINT Border$

            REPEAT
                GETFILE myfile$ FROM mydir
                IF LEFT$(myfile$,1)== "." OR ISFALSE(LEN(myfile$)) OR REGEX(myfile$,Exclude$) THEN
                    CONTINUE
                ELSE
                    Menu$(STR$(Count)) = myfile$
                    PRINT Count,") ", myfile$
                    INCR Count
                ENDIF
            UNTIL ISFALSE(LEN(myfile$))

            CLOSE DIRECTORY mydir

            PRINT Border$

            Amount = NRKEYS(Menu$)
            PRINT

            INPUT "Select User: ",Selection$
            blah = VAL(Selection$)
            IF (blah < 1 OR blah > Amount) THEN
                PRINT ">>> Invalid Selection <<"
                SLEEP 1000
                CONTINUE
            ELSE
                Loop = FALSE
            ENDIF
        WEND
        RETURN Menu$(Selection$)
    END FUNCTION

    selected$ = SelectFolder$("Armando's Test Menu","/home")

    PRINT
    PRINT "You Selected: ", selected$

jrs@jrs-laptop:~/BaCon/bacon-3.7.3$ ./air Armando's Test Menu ------------------- 1) jrs ------------------- Select User: 1 You Selected: jrs jrs@jrs-laptop:~/BaCon/bacon-3.7.3$

This is a much easier task than I first imagined.

Title: Re: Menu me this....
Post by: AIR on October 22, 2018, 02:27:53 PM

Quote from: John on October 22, 2018, 02:20:18 PM

I gave your BaCon example a try but had to make the _Bool change and change /Users to /home.

Hmm. It worked with bool here on macOS and Raspbian, are you using the latest Bacon?

Quote from: John

This is a much easier task than I first imagined.

Yeah, it's all about putting the pieces together. Once you get there, it's pretty easy when you look back...

AIR.

Title: Re: Menu me this....
Post by: AIR on October 22, 2018, 02:30:11 PM

NIM VERSION

Code: Text

import os,ospaths,strutils,tables
 
proc input(prompt: string): int =
    var 
        selection:string
 
    stdout.write prompt
    selection = readLine(stdin)
    return selection.parseInt
 
 
proc SelectFolder(menu_title:string, path:string): string =
    var
        Count,Choice:int
        Loop = true
        userFolder,selected, Border:string
        Exclude = ["Shared","Guest"]
        menu = initTable[int, string]()
    
    Border = "-".repeat(menu_title.len)
 
    while Loop:
        stdout.write "\x1b[2J\x1b[H"
        echo menu_title
        echo Border
        Count = 1
        for kind, path in walkDir(path):
            userFolder = path.extractFilename
            if userFolder.startsWith(".") or Exclude.contains(userFolder):
                continue
            else:
                menu[Count] = userFolder
                echo Count,") ", userFolder
                Count += 1
        
        echo Border
 
        try:
            Choice = input("Select a User Folder: ")
            selected = menu[Choice]
            Loop = false
        except KeyError, ValueError:
            echo ">> Invalid Selection <<"
            sleep 1000
            continue
        
    return selected
 
var selected = SelectFolder("Armando's Test Menu","/Users")
 
echo "\nSelected User: ",selected

AIR.

Title: Re: Menu me this....
Post by: John on October 22, 2018, 02:42:24 PM

On Linux and I assume iOS one must run this as root.

Title: Re: Menu me this....
Post by: AIR on October 22, 2018, 02:43:55 PM

Quote from: John on October 22, 2018, 02:42:24 PM

On Linux and I assume iOS one must run this as root.

Not the menu. If you go ahead and add code to do the actual backup, then yes. But that's outside of the scope of this "challenge"...

BTW, root is not usually in the /home folder. It's typically at /root in Linux, and in /var under macOS (not iOS).

Title: Re: Menu me this....
Post by: John on October 22, 2018, 04:12:52 PM

Quote from: AIR

BTW, root is not usually in the /home folder. It's typically at /root in Linux, and in /var under macOS (not iOS).

Bad assumption on my part without checking first.

Here is the Script BASIC submission.

Code: ScriptBasic

fn = FREEFILE()
Exclude = "Guest|Shared"
Title = "Armando's Test Menu"
file_list = ""
Border = STRING(LEN(Title), "-")
Search_Options = SbCollectDirectories
OPEN DIRECTORY "/home" PATTERN "" OPTION Search_Options AS #fn
RESET DIRECTORY #fn
fName = NEXTFILE(fn)
WHILE fName <> undef
  IF NOT INSTR(Exclude, fName) THEN file_list &= fName & "\n"
  file_list &= fName & "\n"
  fName = NEXTFILE(fn)
WEND
CLOSE DIRECTORY #fn
SPLITA file_list BY "\n" TO users
PRINT Title,"\n",Border,"\n"
FOR idx = 0 TO UBOUND(users)
  PRINT idx,") ",users[idx],"\n"
NEXT
PRINT Border,"\n","Select User: "
LINE INPUT uid
uid = VAL(CHOMP(uid))
PRINT "You Selected: ", users[uid], "\n"
 

jrs@jrs-laptop:~/sb/examples/test$ scriba air.sb Armando's Test Menu ------------------- 0) jrs ------------------- Select User: 0 You Selected: jrs jrs@jrs-laptop:~/sb/examples/test$

Title: Re: Menu me this....
Post by: AIR on October 22, 2018, 04:28:06 PM

Code: [Select]

Armando's Test Menu
-------------------
[0] .localized
[1] Shared
[2] Shared
[3] Guest
[4] Guest
[5] riveraa
-------------------
Select User: 9
You Selected: undef

It's not filtering plus I'm seeing dupes on my Mac. Also missing the Warning message if the selection is out of range. And requirement #2 isn't exactly met.\

Dupes are due to this:

Code: ScriptBasic

WHILE fName <> undef
  IF NOT INSTR(Exclude, fName) THEN file_list &= fName & "\n"
  file_list &= fName & "\n"
  fName = NEXTFILE(fn)
WEND

You added to file_list twice. LOL. I hate when that happens!!

AIR.

Title: Re: Menu me this....
Post by: John on October 22, 2018, 04:52:45 PM

It was going to be a IF / END IF but decided on one line and forgot to delete it. ;D

Try this.

Code: ScriptBasic

' AIR - Select user for backup
 
FUNCTION SelectFolder(Title, Folder)
  LOCAL fn, Exclude, Border, file_list, fName, users, idx, uid
  fn = FREEFILE()
  Exclude = "Guest|Shared"
  Border = STRING(LEN(Title), "-")
  file_list = ""
  OPEN DIRECTORY Folder PATTERN "" OPTION SbCollectDirectories AS #fn
  RESET DIRECTORY #fn
  fName = NEXTFILE(fn)
  WHILE fName <> undef
    IF NOT INSTR(Exclude, fName) = undef THEN file_list &= fName & "\n"
    fName = NEXTFILE(fn)
  WEND
  CLOSE DIRECTORY #fn
  SPLITA file_list BY "\n" TO users
  PRINT Title,"\n",Border,"\n"
  FOR idx = 0 TO UBOUND(users)
    PRINT idx,") ",users[idx],"\n"
  NEXT
  Enter:
  PRINT Border,"\n","Select User: "
  LINE INPUT uid
  uid = VAL(CHOMP(uid))
  IF uid > UBOUND(users) THEN
    PRINT ">> Invalid Selection <<", "\n"
    GOTO Enter
  END IF
  SelectFolder = users[uid]
END FUNCTION
selected = SelectFolder("Armando's Test Menu", "/home")
PRINT "You Selected: ", selected, "\n"
 

jrs@jrs-laptop:~/sb/examples/test$ scriba air.sb Armando's Test Menu ------------------- 0) jrs ------------------- Select User: 1 >> Invalid Selection << ------------------- Select User: 0 You Selected: jrs jrs@jrs-laptop:~/sb/examples/test$ ls -l /home total 12 drwxr-xr-x 2 root root 4096 Oct 22 16:48 Guest drwxr-xr-x 133 jrs jrs 4096 Oct 22 14:01 jrs drwxr-xr-x 2 root root 4096 Oct 22 16:48 Shared jrs@jrs-laptop:~/sb/examples/test$

Title: Re: Menu me this....
Post by: AIR on October 22, 2018, 06:04:05 PM

Code: [Select]

Armando's Test Menu
-------------------
0) .localized
1) riveraa
-------------------
Select User:

That's what I get with your code on my Mac.

EDIT: You also don't account for non-numeric input, so if I input a letter or a string of letters, the result is the first entry in the AssocArray.

I get the following with SB code that I wrote (I modified what you originally posted):

Code: [Select]

Armando's Test Menu
-------------------
1) riveraa
-------------------
Select User:

Here's my take on it, this version refreshes the screen after showing the warning message:

Code: ScriptBasic

FUNCTION  SelectFolder(Title,Path)
  fn = FREEFILE()
  Exclude = "Guest|Shared|Public"
  file_list = ""
  myloop = 1
  Border = STRING(LEN(Title), "-")
  Search_Options = SbCollectDirectories
 
 
  WHILE myloop
    OPEN DIRECTORY Path PATTERN "" OPTION Search_Options AS #fn
    RESET DIRECTORY #fn
    fName = NEXTFILE(fn)
 
    WHILE fName <> undef
      IF NOT INSTR(Exclude, fName) = undef THEN 
        IF LEFT(fName,1) <> "." THEN file_list &= fName & "\n"  
      END IF
      fName = NEXTFILE(fn)
    WEND
 
    CLOSE DIRECTORY #fn
 
    SPLITA file_list BY "\n" TO users
 
    PRINT "\x1b[2J\x1b[H"
 
    PRINT Title,"\n",Border,"\n"
 
    FOR idx = 0 TO UBOUND(users)
        PRINT idx+1,") ",users[idx],"\n"
    NEXT
 
    PRINT Border,"\n","Select User: "
 
    LINE INPUT uid
 
    uid = VAL(CHOMP(uid-1))
 
    IF users[uid] = undef THEN
      PRINT ">> Invalid Selection <<\n"
      SLEEP 1
      file_list = undef
    ELSE
      myloop = 0
    END IF
  WEND
 
  SelectFolder = users[uid]
END FUNCTION
 
selected = SelectFolder("Armando's Test Menu", "/Users")
 
PRINT "\nYou Selected: ",selected,"\n"

AIR.

Title: Re: Menu me this....
Post by: John on October 22, 2018, 07:14:36 PM

Here is my last version with your improvements running on Windows 7 32 bit OS. Something strange going on with returning lower case filenames The file explorer, DIR and SB.display different results. (another reason why I dislike Windows)

Code: ScriptBasic

' AIR - Select user for backup
 
FUNCTION SelectFolder(Title, Folder)
  LOCAL fn, Exclude, Border, Search_Options, file_list, fName, users, idx, uid
  fn = FREEFILE()
  Exclude = "Default|Public"
  Border = STRING(LEN(Title), "-")
  file_list = ""
  OPEN DIRECTORY Folder PATTERN "" OPTION SbCollectDirectories AS #fn
  RESET DIRECTORY #fn
  fName = NEXTFILE(fn)
  WHILE fName <> undef
    IF NOT INSTR(Exclude, fName) = undef THEN file_list &= fName & "\n"
    fName = NEXTFILE(fn)
  WEND
  CLOSE DIRECTORY #fn
  SPLITA file_list BY "\n" TO users
  Retry:
  PRINT Title,"\n",Border,"\n"
  FOR idx = 0 TO UBOUND(users)
    PRINT idx + 1,") ",users[idx],"\n"
  NEXT
  PRINT Border,"\n","Select User: "
  LINE INPUT uid
  uid = CHOMP(uid)
  IF uid - 1 > UBOUND(users) OR users[uid - 1] = undef THEN
    PRINT ">> Invalid Selection <<", "\n\n"
    GOTO Retry
  END IF
  SelectFolder = users[uid -1]
END FUNCTION
PRINT "You Selected: ", SelectFolder("Armando's Test Menu", "/Users"), "\n"
 

Title: Re: Menu me this....
Post by: AIR on October 22, 2018, 08:13:19 PM

Ruby Version

In case Tomaaz is lurking.... 8)

Code: Ruby

#!/usr/bin/env ruby
 
def SelectFolder(title,path)
    $menu = {}
 
    $Loop = 1
    $Exclude = ['Shared','Guest','Public']
    $Border = "-"*title.length
 
    while $Loop == 1
        puts "\e[H\e[2J"
        puts title
        puts $Border
        $Count = 1
        for fPath in Dir.glob(path + '/*')
            $fNAME = File.basename("#{fPath}")
 
            if not $Exclude.include? "#{$fNAME}"
                puts $Count.to_s + ") " + "#{$fNAME}"
                $menu[$Count] = "#{$fNAME}"
                $Count+=1
            end
        end
        puts $Border
        print "\nSelect User: "
        choice = gets
        $selected = $menu[choice.to_i]
        if $selected
            $Loop = 0
        else
            puts ">> Invalid Selection <<"
            sleep 1
            next
        end
 
    end
    return $selected
end
 
$selected = SelectFolder("Armando's Test Menu","/Users")
 
puts "\nYou Selected: #{$selected}"

I really don't like the Ruby syntax, but to each his/her own....

AIR.

Title: Re: Menu me this....
Post by: John on October 22, 2018, 11:23:32 PM

I added an ANSI escape sequence to the Linux version to clear the screen if an invaild selection is made before retrying. It doesn't seem to work on Windows, surprised?

Code: ScriptBasic

'' AIR - Select user for backup
 
FUNCTION SelectFolder(Title, Folder)
  LOCAL fn, Exclude, Border, Search_Options, file_list, fName, users, idx, uid
  fn = FREEFILE()
  Exclude = "Guest|Shared"
  Border = STRING(LEN(Title), "-")
  file_list = ""
  OPEN DIRECTORY Folder PATTERN "" OPTION SbCollectDirectories AS #fn
  RESET DIRECTORY #fn
  fName = NEXTFILE(fn)
  WHILE fName <> undef
    IF NOT INSTR(Exclude, fName) = undef THEN file_list &= fName & "\n"
    fName = NEXTFILE(fn)
  WEND
  CLOSE DIRECTORY #fn
  Retry:
  SPLITA file_list BY "\n" TO users
  PRINT Title,"\n",Border,"\n"
  FOR idx = 0 TO UBOUND(users)
    PRINT idx + 1,") ",users[idx],"\n"
  NEXT
  PRINT Border,"\n","Select User: "
  LINE INPUT uid
  uid = CHOMP(uid)
  IF users[uid - 1] = undef THEN
    PRINT "\033[H\033[2J"
    UNDEF users
    GOTO Retry
  END IF
  SelectFolder = users[uid -1]
END FUNCTION
Selected = SelectFolder("Armando's Test Menu", "/home")
PRINT "You Selected: ", Selected, "\n"
 

Title: Re: Menu me this....
Post by: AIR on October 23, 2018, 04:47:55 PM

Quote from: John on October 22, 2018, 11:23:32 PM

I added an ANSI escape sequence to the Linux version to clear the screen if an invaild selection is made before retrying. It doesn't seem to work on Windows, surprised?

In Windows 10, there is supposed to be a registry flag you can set to enable the built-in support for ANSI sequences. Or you can try loading up Ansi.sys (16 bit though!!) or one of the later Ansi.sys enhancements.

Or you can just exec the "cls" command...

John, does SB support conditional execution based on OS? Like an #IFDEF in C?

AIR.

Title: Re: Menu me this....
Post by: John on October 23, 2018, 04:55:18 PM

Quote

John, does SB support conditional execution based on OS? Like an #IFDEF in C?

The SB OPTION feature is a good example of conditional code execution. The SB ENVIRON() function returns a wealth of information about what you're running under. The conditional code execution could be based on that in BASIC.

I still have one more round for your challenge which is to give it an ANSI dress. (color / line graphics)

Any idea how you want to handle the Windows version of this and the issues I describe in a previous post?

Title: Re: Menu me this....
Post by: AIR on October 23, 2018, 06:09:58 PM

SB apparently doesn't honor the Hidden attribute for files/folders, so you'll have to add those "extra" directories to the filter list.

Title: Re: Menu me this....
Post by: John on October 23, 2018, 06:22:37 PM

Since SB Windows is returning file names in lowrer case, does it matter for the choice value returned?

Title: Re: Menu me this....
Post by: AIR on October 23, 2018, 07:04:13 PM

Not directly, since that is how SB is returning the directory name itself when in Windows. But it will affect the exclusions unless they are also all lowercase.

The conversion to lowercase is done in the file "filesys.c", in the "file_readdir" function (which I believe NEXTFILE actually calls).

Within that function, this line:

Code: C

for( ; *s ; s++ )if( isupper(*s) )*s = tolower(*s);

Changes the returned filename to all lowercase. This is only enabled when SB is compiled for Windows.

AIR.

Title: Re: Menu me this....
Post by: John on October 23, 2018, 07:12:49 PM

That's just the tip of the iceberg. What about unicode file names?

Title: Re: Menu me this....
Post by: AIR on October 23, 2018, 07:35:17 PM

If SB doesn't support unicode presently, you would have to alter at the very least all file-related functions so that they would use the "W" variant of the native C functions instead of the "A" (Ansi) variant which if I remember from my Windows days is the default.

You would also probably need to alter some of the string functions and how the buffers themselves are allocated and removed.

Not a task for the faint of heart. That's my ultra high level view, anyway.

But that conversation really doesn't belong in this thread.

Title: Re: Menu me this....
Post by: John on October 23, 2018, 07:58:24 PM

Oxygen Basic is currently going through that transistion.

This might be a way SB can deal with unicode.

https://www.gnu.org/software/libunistring/manual/

Title: Re: Menu me this....
Post by: AIR on October 24, 2018, 08:44:59 AM

FreePascal Version (Tested on macOS and Windows 10)

Code: Pascal

Program MenuDemo;
{$mode objfpc}{$H+}
 
 
Uses SysUtils, StrUtils, Crt;
 
Function SelectFolder(Title,Path:String): String;
    Var 
        Info : TSearchRec;
        Count, Selection : Longint;
        Menu  : array[0..14] of String;
        Choice, Border: String;
        Loop : Boolean = True;
        Exclude: array[0..2] of String = ('Shared','Public','Guest');
 
    Begin
        Repeat
            ClrScr;
            Border := DupeString('-',Length(Title));
            Writeln(Title);
            Writeln(Border);
            Count:=0;
            If FindFirst (Path + '/*',faDirectory,Info)=0 then begin
                Repeat
                    With Info do begin
                        If (Attr and faDirectory) = faDirectory then begin
                            If ( LeftStr(Name,1) <> '.' ) AND ( AnsiIndexStr(Name,Exclude) = -1 ) then begin
                                Writeln (Count+1,') ',Name);
                                Menu[Count] := Name;
                                Inc(Count);
                            end;
                        end;
                    end;
                Until FindNext(info) <> 0;
            end;
 
            FindClose(Info);
 
            Writeln(Border);
            
            Write ('Select User: ');
            ReadLn(Choice);
 
            try
                Selection := StrToInt(Choice);
                If (Selection < 1) Or (Selection > Count) Then
                    raise Exception.Create('Out of Range');
                Loop := False;
            except
                begin
                    Writeln('>> Invalid Selection <<');
                    Sleep (1000);
                    Continue;
                end;
            end;
 
        Until Loop = False;
 
        Result := menu[Selection-1];
End;
 
 
{** PROGRAM START **}
 
Var
    Selected: String;
 
Begin
    Selected := SelectFolder('Armando''s Test Menu', '/Users');
 
    Writeln(sLineBreak,'You Selected: ', Selected, sLineBreak);
End.
 

I haven't used Pascal in a LOOOOOONG time. The last time was when I created an IDE for Hotbasic using Delphi...about 10 years ago. It was fun gong back in time, so to speak...

AIR.

Title: Re: Menu me this....
Post by: John on October 24, 2018, 09:05:13 AM

I wish that wasted effort with Hot Basic could have been used to advance Script BASIC instead. :-\

Title: Re: Menu me this....
Post by: AIR on October 24, 2018, 09:55:37 AM

I learned a LOT from Jim, both ASM _AND_ C as well as coding in general. As much as he's always hated on C, he's very good at it. Go figure.

I also learned a LOT from that community, which was always willing to answer questions and explain how they were able to enhance the language with their own crafted modules.

So not a wasted effort from my point of view, because if nothing else I was taught how NOT to wait for "someone else to do it".....

AIR.

Title: Re: Menu me this....
Post by: John on October 24, 2018, 10:07:38 AM

Experiance doesn't come cheap.

Title: Re: Menu me this....
Post by: AIR on October 24, 2018, 11:53:37 AM

HotBasic Version 8) 8) 8)

Code: Text

$apptype console: $typecheck on
 
Declare function SelectFolder(Title$ as string, Path$ as string) as string
 
function SelectFolder(Title$ as string, Path$ as string) as string
    defstr r$,border$
    dim menu(15) as string*64
    deflng count,selection,theLoop
    dim exclude as LIST
 
    theLoop = 1
    border$ = string$(Title$.length,"-")
    exclude.AddItems("All Users","Default","Default User","Public")
 
    while theLoop
        cls
        count = 0
 
        print Title$
        print border$
 
        r$ = dir$(Path$ + "/*",&H10)
 
        do
            if r$[1] <> "." AND exclude.indexof(r$) = -1 then
                menu(count) = r$
                inc count
                print str$(count) + ") " + r$
            end if
            r$ = dir$
        loop until r$.length = 0
 
        print border$
        input "Select User: "; selection
 
        if selection < 1 or selection > count then
            print ">> Invalid Selection <<"
            sleep .8
        else
            theLoop = 0
        end if
    wend
    result =  menu(selection-1)
end function
 
' ** PROGRAM START **
defstr SelectedUser = SelectFolder("Armando's Test Menu","/Users")
print CRLF + "You Selected: " + SelectedUser
 

Man this takes me back.....

AIR.

Title: Re: Menu me this....
Post by: John on October 24, 2018, 02:53:00 PM

Wow!

It has been a long time since I seen Hot Basic code. Is Jim still in the game?

Curious, what are your thoughts about the unicode solution I proposed?

Title: Re: Menu me this....
Post by: AIR on October 24, 2018, 10:07:28 PM

C VERSION

Not 100% happy with this, but it seems to work okay...

Code: C

#include <dirent.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
 
#define NELEMS(x)  (sizeof(x) / sizeof((x)[0]))
 
const char* exclude[] = {"Guest","Shared","Public"};
 
char * SelectFolder(const char* Title, const char *Path){
    char *line = NULL, *end, *menu[14];
    char **ptr = menu;
    int selected, count, i=0, loop = 1;
    size_t len = 1, read = 0;
 
 
    while (loop) {
        printf("\033[2J\033[H");
        printf("%s\n",Title);
        printf("%.*s\n", (int)strlen(Title), "------------------------------------------");
        i = count = 0;
 
        DIR *dir = opendir(Path);
 
        struct dirent *entry = readdir(dir);
 
        while (i< NELEMS(exclude)) {
            while (entry != NULL) {
                if ( (entry->d_type == DT_DIR) && (strncmp(entry->d_name,".",1 ) != 0) && (strcmp(entry->d_name,exclude[i]) !=0)) {
                    printf("%i) %s\n", count+1,entry->d_name);
                    menu[count] = entry->d_name;
                    count++;
                }
                entry = readdir(dir);
                
            }
            i++;
        }
       
        closedir(dir);
 
        printf("%.*s\n", (int)strlen(Title), "------------------------------------------");
        printf("%s","Select User: ");
        read = getline(&line, &len, stdin);
        selected = strtol(line,&end,10);
        printf("\n");
        
 
        if ( (selected <1) || (selected > count) ) {
            printf("%s\n",">> Invalid Selection <<");
            sleep(1);
        }else{
            loop = 0;
            free(line);
        }
            
    }
    return strdup(menu[selected-1]);
}
 
int main() {
    char* selected = SelectFolder("Armando's Test Menu","/Users");
    printf("You Selected: %s\n\n",selected);
    free(selected);
    return 0;
}
 
 

I think this is the last language I'll post...waiting on others to jump in....

AIR.

Title: Re: Menu me this....
Post by: John on October 24, 2018, 10:14:49 PM

Maybe Charles can find time to represent Oxygen Basic in this challenge?

Hopefully he will have better luck under Windows then I did with SB.

Title: Re: Menu me this....
Post by: AIR on October 25, 2018, 08:00:46 PM

Quote from: John on October 24, 2018, 10:14:49 PM

Hopefully he will have better luck under Windows then I did with SB.

I don't see what the issue is with SB itself other than the forced lowercasing of the returned folder list.

IF you make the change in filesys.c that I suggested previously (just comment that line), and edit the script as I have below, it works fine:

Code: ScriptBasic

' AIR - Select user for backup
    
FUNCTION SelectFolder(Title, Folder)
    LOCAL fn, Exclude, Border, Search_Options, file_list, fName, users, idx, uid, ret
    fn = FREEFILE()
 
    Exclude = ".|All Users|Default|Default User|Public|desktop.ini"
 
    Border = STRING(LEN(Title), "-")
 
    OPEN DIRECTORY Folder PATTERN "" OPTION SbCollectDirectories AS #fn
 
    RESET DIRECTORY #fn
 
    fName = NEXTFILE(#fn)
 
    WHILE fName <> undef
        IF NOT INSTR(Exclude, fName) = undef THEN file_list &= fName & "\n"
        fName = NEXTFILE(#fn)
    WEND
 
    CLOSE DIRECTORY #fn
 
Retry:
    users = undef
 
    ret = EXECUTE("cmd /c cls",-1,PID)
 
    SPLITA file_list BY "\n" TO users
    
    PRINT Title,"\n",Border,"\n"
 
    FOR idx = 0 TO UBOUND(users)
        PRINT idx + 1,") ",users[idx],"\n"
    NEXT
 
    PRINT Border,"\n","Select User: "
 
    LINE INPUT uid
 
    uid = CHOMP(uid)
 
    IF uid - 1 > UBOUND(users) OR users[uid - 1] = undef THEN
        PRINT "\n>> Invalid Selection <<"
        SLEEP 1
        GOTO Retry
    END IF
    
    SelectFolder = users[uid -1]
 
END FUNCTION
 
selectedUser = SelectFolder("Armando's Test Menu", "/Users")
 
PRINT "\nYou Selected: ", selectedUser, "\n"
    
 

AIR.

P.S. When posting code, please format it so that it's easier to read/follow (as I've done above). It's easy to miss something, and also hard to follow the flow of the code, when it's densely packed. Thanks!!

Title: Re: Menu me this....
Post by: John on October 25, 2018, 11:55:27 PM

Thanks for the confirmation your suggested change fixes the Windows issue. Why do you think Peter forced lower case for Windows only?

I will try to make the SB code I submit more readable. I may have caught Tomaaz's one line wonder disease.

Title: Re: Menu me this....
Post by: Mike Lobanovsky on October 26, 2018, 03:32:34 AM

Quote from: AIR on October 25, 2018, 08:00:46 PM

... hard to follow the flow of the code, when it's densely packed.

Not so for me actually. I prefer camel case, 8-px monospace fonts, 2-char tabs, indentation guides and syntax highlighting, and I code on every line leaving one blank line between functions. :)

Title: Re: Menu me this....
Post by: Mike Lobanovsky on October 26, 2018, 03:47:48 AM

Quote from: John on October 25, 2018, 11:55:27 PM

Why do you think Peter forced lower case for Windows only?

Obviously because Windows pathnames and filenames are case insensitive. Windows also supports forward and back slashes indiscriminately. It even allows them to be intermixed at will. :)

Title: Re: Menu me this....
Post by: John on October 26, 2018, 07:23:57 AM

Does that also hold true for unicode filenames?

I'm still going ahead with AIR's recommended change as it would be confusing to users seeing their filenames changed.

Title: Re: Menu me this....
Post by: Mike Lobanovsky on October 26, 2018, 12:21:31 PM

No, Unicode pathnames are a horror and you're done if you don't have an appropriate language support installed on your box. You won't be able to either access, or rename, or delete the offending file. But then, upper-/lower-casing isn't going to work for you either.

The same goes about Linux chars not allowed in the Windows pathnames created or copied to the Windows hosts from under their Linux VM's.

Avoid localized path/file names under Windows at all times and use ANSI whenever possible because there may be potential users whose environments are not equipped with the corresponding locale.

Not that it matters much to Anglo-Saxon users though whose locale support is built into the MS Windows installations natively. ;)

Title: Re: Menu me this....
Post by: John on October 26, 2018, 01:21:55 PM

Thanks Mike for your thoughts on unicode. I'm going take your advice as well.

AllBASIC Forum

BASIC User Group => Code Challenges => Topic started by: AIR on October 22, 2018, 12:07:41 PM